Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.12 does not support a JDK 11 target #18067

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 22, 2021

And in any case, it will need to be -target:11 when we switch to 2.13.

And in any case, it will need to be -target:11 when we switch to 2.13.
@gsmet
Copy link
Member Author

gsmet commented Jun 22, 2021

@famod I'm surprised this change triggered so many native builds?

@gsmet gsmet merged commit e60b4f9 into quarkusio:main Jun 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
@famod
Copy link
Member

famod commented Jun 22, 2021

@gsmet I'll have a look later today.

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
@famod
Copy link
Member

famod commented Jun 22, 2021

Interesting:

[INFO] Scanning for projects...
[INFO] gitflow-incremental-builder 3.14.2 starting...
[INFO] Reference commit of branch HEAD is commit of id: commit 47f2eb37b4d9de6424ca9df56be67849b562455e 1624350667 ------p
[INFO] Reference commit of branch origin/main is commit of id: commit 4450e9e05a914fc46c11d6eb372e5bbb64966bb2 1624350755 ------p
[INFO] Using merge base of id: commit 65e3aa05e088355b014d20b197086eac83ec888d 1624346942 --tr-sp
Warning:  Ignoring changed file in non-reactor module: /home/runner/work/quarkus/quarkus/integration-tests/scala/src/test/resources/projects/classic-scala/pom.xml
[INFO] ------------------------------------------------------------------------
[INFO] No changed artifacts detected: Executing validate goal on current project only, skipping all submodules.
[INFO] gitflow-incremental-builder exiting...

So, no changes have been detected. 🤔 I'll check that warning.

PS: No changes means full build btw. because an empty list of changed modules is considered to be the "GIB disabled" case in CI.

@famod
Copy link
Member

famod commented Jun 22, 2021

@gsmet
Copy link
Member Author

gsmet commented Jun 22, 2021

I suppose it's because the change was inside a nested Maven project maybe?

@famod
Copy link
Member

famod commented Jun 22, 2021

Yes, I think so. I'll have to take into account src.

@famod
Copy link
Member

famod commented Jun 23, 2021

I have a fix for this. I'll release GIB 3.14.3 in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants