Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the compilation target to JDK 11 #18047

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Set the compilation target to JDK 11 #18047

merged 1 commit into from
Jun 21, 2021

Conversation

m1ngyuan
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/scala labels Jun 21, 2021
@m1ngyuan m1ngyuan marked this pull request as ready for review June 21, 2021 15:53
gsmet
gsmet approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

famod
famod reviewed Jun 21, 2021
View reviewed changes
build-parent/pom.xml Outdated
@@ -874,7 +874,7 @@
maven-antrun-plugin
</artifactId>
<versionRange>
[1.8,)
[11,)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for the reminder.

@Sanne Sanne merged commit e100a8f into quarkusio:main Jun 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 21, 2021
@m1ngyuan m1ngyuan deleted the jdk_11 branch June 21, 2021 17:39
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 26e6ee4

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
⌛ JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
✖ Native Tests - Data3 Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - Spring Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - gRPC Build ⚠️ Check → Logs Raw logs

@gsmet
Copy link
Member

gsmet commented Jun 21, 2021

@Sanne hmmm, maybe we should have waited for the CI run to complete?

@Sanne
Copy link
Member

Sanne commented Jun 21, 2021

@gsmet I did.. but the PR was push-forced just about the same time :/

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2021

Failing Jobs - Building c251dc6

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

@gsmet
Copy link
Member

gsmet commented Jun 22, 2021

This PR broke the build, I'm working on fixing it.

@gsmet
Copy link
Member

gsmet commented Jun 22, 2021

#18067

@Sanne
Copy link
Member

Sanne commented Jun 22, 2021

I'm sorry :/ Thanks!

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/scala
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@m1ngyuan @gsmet @Sanne @famod