Pull docker image when necessary for @QuarkusIntegrationTest #17753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Jun 8, 2021
| @@ -145,8 +147,9 @@ public void buildFromNative(ContainerImageConfig containerImageConfig, JibConfig | |||
| List<ContainerImageLabelBuildItem> containerImageLabels, | |||
| BuildProducer<ArtifactResultBuildItem> artifactResultProducer) { | |||
|
|
|||
| if (!containerImageConfig.build && !containerImageConfig.push && !buildRequest.isPresent() | |||
| && !pushRequest.isPresent()) { | |||
| Boolean buildContainerImage = containerImageConfig.build || buildRequest.isPresent(); | |||
There was a problem hiding this comment.
Suggested change
| Boolean buildContainerImage = containerImageConfig.build || buildRequest.isPresent(); | |
| boolean buildContainerImage = containerImageConfig.build || buildRequest.isPresent(); |
There was a problem hiding this comment.
I wanted to use toString.
Obviously it could be done with a string concat, but I think it doesn't matter 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where jib was used to push the container image to the registry but not build it locally
Fixes: #17730