QuarkusIntegrationTest docker run, does not pull the image

[bdevreugd-vialis]

In our CI-build the docker image is pushed to nexus using jib, the integration-test is then run on a docker daemon. The first time it will correctly pull the image (which sometimes causes a timeout, because it is not within the 10 seconds wait period:

quarkus/test-framework/common/src/main/java/io/quarkus/test/common/LauncherUtil.java

Line 68 in 11607b6

signal.await(10, TimeUnit.SECONDS);

The second time (and all tries after that), it will reuse the docker image inside the docker daemon!

Basically, it should pull the image first and after that run the image. I know there is an option called --pull=always on run, but that doesn't work on older docker daemons.

So basically something like:

List<String> args = new ArrayList<>();
args.add("docker");
args.add("pull");
args.add(containerImage);
ProcessBuilder(args).redirectError(logFile.toFile()).redirectOutput(logFile.toFile()).start().waitFor();

Before the actual docker run here:

quarkus/test-framework/common/src/main/java/io/quarkus/test/common/DockerContainerLauncher.java

Lines 71 to 73 in 11607b6

	List<String> args = new ArrayList<>();
	args.add("docker"); // TODO: determine this dynamically?
	args.add("run");

This will also fix the timeout if the pull on the first run takes to long.

[quarkus-bot]

/cc @geoand

[geoand]

Good point!

[geoand]

I'll actually make the pull conditional on whether or not the image was only pushed