-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Maven 3.8.1 and use mvnw consequently in GH workflows #16249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gsmet perhaps we should backport this to 1.13.1.Final? The changes don't seem to be (too) aggressive IMHO 😃 |
I confirm that this PR fixes #16233 |
@famod I pushed an additional commit to adjust the |
Windows tests are still timing out. 😒 Btw:
Although we already have GIB 3.14.0 in |
@famod it's the second time the Scala tests are failing for this PR so I wonder if we don't have a real issue. |
Checking on my Windows box. |
Hm, strange. Ontopic @gsmet: All Scala ITs run just fine locally on Windows 10. 🤷♂️ |
Those Windows runs are a complete mess, OutOfMemory in Gradle and lot's of process related test failures (mostly in |
FWIW, |
Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka# Tests: 10
+ Success: 8
- Failures: 0
- Errors: 2
! Skipped: 0 ❌
|
@gsmet there is a small issue in the bot logic: It is saying that "Gradle Tests - JDK 11 Windows" failed in Back to topic: I've seen |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/scala# Tests: 3
+ Success: 1
- Failures: 0
- Errors: 2
! Skipped: 0 ❌
|
I still don't have a clue why exactly those scala tests are failing but to me that jprocesses lib just seems buggy:
It hasn't seen a release in years and it's known to leak file handles on Windows: profesorfalken/WMI4Java#18 I propose we ditch it once JDK8 support has been dropped (after the 2.x branch merge) and give |
I'm a bit nervous about merging this. We don't have that many issues in other PRs. |
asked for a rerun. |
Yeah, me too. I just fail to understand how this is related but I haven't had much time to dig deeper. |
Btw, I have another GIB version ready which removes that warning. I'm going to push it to this PR in case CI still fails |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka# Tests: 10
+ Success: 8
- Failures: 0
- Errors: 2
! Skipped: 0 ❌
|
That's new: All Windows jobs fail right away with:
Must have something to do with |
Ah crap, it's a If the file is checked out with LF or Xmx5g doesn't have a trailing newline it works. |
Discussion started for this ^ |
Note: Still working on that one memory problem. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d4dec23
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/kubernetes/quarkus-standard-way✖ ⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5a6761e
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 15 #📦 integration-tests/kafka✖ ✖ ⚙️ JVM Tests - JDK 8 #📦 integration-tests/kafka✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f76ac5e
Full information is available in the Build summary check run. Test Failures⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ |
Ha! Looking good now ( |
So I ran this (again) with I'll resolve yet another conflict and then it would be nice if we could merge this @gsmet. |
Thanks for this work! |
@gsmet Thanks for merging! WDYT about backporting? Wait for more user complaints instead? |
One of the pains with 3.8.z is that it blocks repositories running on We use Artifactory to cache the downloaded artifacts, we don't have control over all used jdks to adjust the truststore. Users should be notified about this change in the release announce. |
Discussion about if/when to take this in is still ongoing: https://groups.google.com/g/quarkus-dev/c/A-cm9pvviiE
Windows jobs have a hard time in my fork, so let's see how it goes here...
Should help with #16233 but I have not yet tested that specifically.