-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop jprocesses in favor of java.lang.ProcessHandle #16521
Labels
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
Milestone
Comments
famod
added
the
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
label
Apr 14, 2021
Interesting, I didn't even know about jprocesses. I actually had custom code for the IDE link handling that I just removed, so I'm obviously +1 for this |
@famod fancy providing a PR? |
I'm guessing the code in public static void killProcesses(String... cmdParts) {
ProcessHandle.allProcesses()
.filter(processHandle -> {
String cmdLine = processHandle.info().commandLine().orElse(null);
if (cmdLine == null) {
return false;
}
for (String part : cmdParts) {
if (cmdLine.contains(part)) {
return true;
}
}
return false;
})
.forEach(ProcessHandle::destroyForcibly);
} |
Looks like you implemented it already. 😄 |
But yeah, I can provide a PR later this week. |
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
Apr 14, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
Apr 14, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
Apr 14, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
Apr 14, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
Apr 15, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
May 19, 2021
gastaldi
added a commit
to gastaldi/quarkus
that referenced
this issue
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As per #16249 (comment)
jprocesses
has not seen any activity for 3 years and with JDK 8 support now dropped (in main), the OOTBProcessHandle
should be used instead.Implementation ideas
Remove code, write a tiny bit of new code, remove dependency - be happy! 😉
The text was updated successfully, but these errors were encountered: