Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native image - make it possible to generate the dashboard dump file #15041

Merged
merged 1 commit into from
Feb 15, 2021
+12 −0
Merged

Native image - make it possible to generate the dashboard dump file #15041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,12 @@ public static class Debug {
public boolean enabled;
}

/**
* Generate the report files for GraalVM Dashboard.
*/
@ConfigItem
public boolean enableDashboardDump;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable it for one of our ITs in the tree? I don't know if it slows down things a lot or requires a ton of memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dump file has 112M for a simple app. Do we enable reports (used_classes, etc.) for some ITs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's merge as is then. Looks a bit too big for our own good.


/**
* Supported Container runtimes
*/
Expand Down
6 changes: 6 additions & 0 deletions core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,12 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa
} else {
command.add("-H:-StackTrace");
}

if (nativeConfig.enableDashboardDump) {
command.add("-H:DashboardDump=" + outputTargetBuildItem.getBaseName() + "_dashboard.dump");
command.add("-H:+DashboardAll");
}

String executableName = outputTargetBuildItem.getBaseName() + packageConfig.runnerSuffix;
command.add(executableName);

Expand Down