Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native image - make it possible to generate the dashboard dump file #15041

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Native image - make it possible to generate the dashboard dump file #15041

merged 1 commit into from
Feb 15, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 12, 2021

gsmet
gsmet approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@gsmet gsmet added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 12, 2021
gsmet
gsmet reviewed Feb 12, 2021
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
* Generate the report files for GraalVM Dashboard.
*/
@ConfigItem
public boolean enableDashboardDump;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable it for one of our ITs in the tree? I don't know if it slows down things a lot or requires a ton of memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dump file has 112M for a simple app. Do we enable reports (used_classes, etc.) for some ITs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's merge as is then. Looks a bit too big for our own good.

@gsmet gsmet merged commit 8389134 into quarkusio:master Feb 15, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 15, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
@jonathan-meier jonathan-meier mentioned this pull request Feb 16, 2021
Merged
@famod famod removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
1.12.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @gsmet @famod