Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye Reactive Messaging brings in split package usage with leads to warnings logged #38711

Closed
michalvavrik opened this issue Feb 9, 2024 · 9 comments

Comments

@michalvavrik
Copy link
Member

Describe the bug

I have app solely consisting of the SmallRye Reactive Messaging extension and nothing else. When I start my application, I can see warning about split package usage.

Expected behavior

No warnings.

Actual behavior

Following message is logged:

Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives: 
- "io.smallrye.reactive.messaging.health" found in [io.smallrye.reactive:smallrye-reactive-messaging-api::jar, io.smallrye.reactive:smallrye-reactive-messaging-health::jar]

How to Reproduce?

Steps to reproduce the behavior:

  1. quarkus-snapshot-cli create app app2 --extensions=smallrye-reactive-messaging
  2. cd app2/
  3. quarkus dev

Output of uname -a or ver

Fedora 38

Output of java -version

OpenJDK Runtime Environment Temurin-21.0.1+12

Quarkus version or git rev

999-SNAPSHOT

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.3

Additional information

No response

Copy link

quarkus-bot bot commented Feb 9, 2024

/cc @Ladicek (smallrye), @cescoffier (reactive-messaging), @jmartisk (smallrye), @ozangunalp (reactive-messaging), @phillip-kruger (smallrye), @radcortez (smallrye)

@cescoffier
Copy link
Member

It's a known problem, but the fix is a big breaking change. So, we will leave with that until the next major.

@michalvavrik
Copy link
Member Author

Alright, thank you. Unless it is already tracked in Quarkus issues, let's keep this one so that I can reference the issue from somewhere.

@ozangunalp
Copy link
Contributor

It'll be fixed in reactive messaging 4.17.0

The module causing the split package is only used in the quarkus reactive messaging extension.
I think we can make the change in a backwards-compatible way.

@cescoffier
Copy link
Member

Yeah, that's what I realized while reviewing. It seems to be fine. So, we should be able to fix it soon.

@mschorsch
Copy link
Contributor

#38518 (comment)

@michalvavrik
Copy link
Member Author

#38518 (comment)

I see @mschorsch , but I disagree with comments in there. I do not use upstream SmallRye Reactive Messaging directly and if Quarkus brings in dependencies that has split package use and then Quarkus itself reports it, that's Quarkus issue. Quarkus can always opt to not report split package if it doesn't want.

Anyway, as Clement and Ozan mentioned, they are going to fix it. Thank you

@cescoffier
Copy link
Member

@ozangunalp did we integrate the fix already?

@ozangunalp
Copy link
Contributor

No, it'll be a part of reactive messaging 4.17

ozangunalp added a commit to ozangunalp/quarkus that referenced this issue Feb 20, 2024
Resolves split package on health package issue quarkusio#38711
gsmet pushed a commit to gsmet/quarkus that referenced this issue Mar 5, 2024
Resolves split package on health package issue quarkusio#38711

(cherry picked from commit e530ff1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants