Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist SmallRye Reactive Messaging split package usage warning logs #340

Conversation

michalvavrik
Copy link
Member

Daily build fails over:

[ERROR] Failures: 
[ERROR]   CodeQuarkusTest.supportedExtensionsSubsetB:185->testRuntime:155 MVNW_DEV log should not contain error or warning lines that are not whitelisted. See testsuite/target/archived-logs/io.quarkus.ts.startstop.CodeQuarkusTest/supportedExtensionsSubsetB/dev-run.log and check these offending lines: 
2024-02-09 15:39:07,725 WARN  [io.qua.arc.dep.SplitPackageProcessor] (build-46) Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives:  ==> expected: <true> but was: <false>
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

which in logs you can see is SR RM, I've opened issue quarkusio/quarkus#38711

2024-02-08 22:31:15,062 WARN  [io.qua.arc.dep.SplitPackageProcessor] (build-34) Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives: 
- "io.smallrye.reactive.messaging.health" found in [io.smallrye.reactive:smallrye-reactive-messaging-api::jar, io.smallrye.reactive:smallrye-reactive-messaging-health::jar]

This PR is whitelisting all split package warnings, for sadly everything after in multiple archives: is in different line.

@michalvavrik
Copy link
Member Author

So the PR fixes one issue and there are others as seen in CI, but these will be handled separately when I find a time next week.

@michalvavrik michalvavrik requested a review from gtroitsk February 9, 2024 16:09
@michalvavrik michalvavrik force-pushed the feature/whitelist-reactive-msg-split-pckg branch from 14ad1a5 to 6013464 Compare February 9, 2024 17:59
@gtroitsk gtroitsk merged commit 23c4d7b into quarkus-qe:main Feb 9, 2024
1 of 9 checks passed
@michalvavrik michalvavrik deleted the feature/whitelist-reactive-msg-split-pckg branch February 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants