-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTEasy Reactive - GZIP support #16425
Comments
/cc @FroMage, @geoand, @stuartwdouglas |
@FroMage Vert.x has built-in gzip support doesn't it? |
Yes. Let's absolutely not do this ourselves if we can avoid it. Especially not with jaxrs interceptors. |
@SaumyaSingh1 is going to look into that |
It's fairly coarse grained, and can already be enabled: https://github.com/stuartwdouglas/quarkus/blob/ac8b99c0d022e7e26eb18834e39282821933c31f/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/HttpConfiguration.java#L223 |
Did I get this right?: That would be sufficient for my case, so the question in here would change to: Should there be a route specific configuration? |
Yeah, that's part of what we need to do here:
|
It is tested: quarkus/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/CompressionTest.java Line 17 in b1dbf7c
At the moment the only way to make it endpoint specific is pretty yuck, you need to add a |
Well, perhaps we can improve that with an annotation to automate it? Also I'm curious as to how that translates to binary data we send: are we compressing images, for example? I'd like for @SaumyaSingh1 to run more tests from the POV of RESTEasy Reactive and get this sort of information. |
I've created an alternative WIP pull request: #24558 |
Description
RESTEasy classic has gzip support via
@org.jboss.resteasy.annotations.GZIP
orquarkus.resteasy.gzip.enabled=true
.It would be great if RR could get gzip support, too.
Implementation thoughts
Reference to RESTEasy classics gzip implementation: DecodingInterceptor, EncodingInterceptor
I guess, the decoding filter needs to be present always, the encoding filter could propably get bound to a
@NameBinding
@GZIP
- if you like to solve only with jax-rs techniques.A global setting similar for that you have for RESTEasy classic could enable or completely disable gzip support by deactivation of that filters.
The text was updated successfully, but these errors were encountered: