Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable gzip content-compression for frontend and update some verions #56

Closed
wants to merge 1 commit into from

Conversation

heubeck
Copy link
Contributor

@heubeck heubeck commented May 11, 2021

According to quarkusio/quarkus#16425 (comment) gzip can be enabled for vert.x-http globally.
Former to the refactoring to resteasy-reactive it was declared on many routes, with this change it becomes active again.

Checklist

  • mvn clean install build and test completes

@heubeck
Copy link
Contributor Author

heubeck commented May 11, 2021

What he says?:

Error: Failed to execute goal on project adoptopenjdk-api-v3-updater: Could not resolve dependencies for project net.adoptopenjdk.api:adoptopenjdk-api-v3-updater:jar:3.0.0-SNAPSHOT: Failed to collect dependencies at io.aexp.nodes.graphql:nodes:jar:0.5.0: Failed to read artifact descriptor for io.aexp.nodes.graphql:nodes:jar:0.5.0: Could not transfer artifact io.aexp.nodes.graphql:nodes:pom:0.5.0 from/to bintray-americanexpress-maven (https://dl.bintray.com/americanexpress/maven): Authorization failed for https://dl.bintray.com/americanexpress/maven/io/aexp/nodes/graphql/nodes/0.5.0/nodes-0.5.0.pom 403 Forbidden -> [Help 1]

@karianna karianna added this to the May 2021 milestone May 13, 2021
@karianna karianna added the enhancement New feature or request label May 13, 2021
@karianna karianna requested a review from johnoliver May 13, 2021 10:05
@karianna
Copy link
Contributor

run tests

@johnoliver
Copy link
Contributor

@heubeck we should have that build issue fixed soon

@heubeck heubeck marked this pull request as draft May 13, 2021 18:26
@heubeck
Copy link
Contributor Author

heubeck commented May 13, 2021

postboning due to quarkusio/quarkus#14695

@karianna karianna modified the milestones: May 2021, June 2021 Jun 6, 2021
@ThoSap
Copy link

ThoSap commented Aug 16, 2021

You can re-enable comoression after this -> quarkusio/quarkus#19426

@karianna
Copy link
Contributor

@heubeck This will need a rebase after the major quarkus upgrade

@ThoSap
Copy link

ThoSap commented Sep 14, 2021

You can re-enable gzip compression again with Quarkus 2.2.2.Final.

@heubeck heubeck closed this Sep 30, 2021
@heubeck heubeck deleted the reactivateGzip branch September 30, 2021 19:25
@heubeck
Copy link
Contributor Author

heubeck commented Sep 30, 2021

superseded by #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants