Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DisabledOnRHBQandWindows to framework one and disable SnappyCompressionIT on RHBQ+Win #2122

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Oct 23, 2024

Summary

The quarkus-qe/quarkus-test-framework#1377 move the DisabledOnRHBQandWindows to Framework. So this PR removing it from kafka-streams-reactive-messaging and switching it to the framework one.

Also it disabling the SnappyCompressionIT on RHBQ + Windows due to https://issues.redhat.com/browse/QUARKUS-5214

This PR need the new framework version. Will rebase and move to ready when the FW bump PR is merged.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 force-pushed the disabled-on-rhbq-and-windows branch from cbbfda8 to 80da829 Compare October 23, 2024 21:17
@jedla97 jedla97 marked this pull request as ready for review October 23, 2024 21:18
@jedla97 jedla97 requested a review from fedinskiy October 23, 2024 21:26
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Oct 23, 2024
Copy link

Following jobs contain at least one flaky test:

  • PR - Linux - JVM build - Latest Version

Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11488305698?pr=2122

Flaky tests:


io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

  • Failure message: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__ ____ __ _____ ___ __ ____ ______ , --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ , -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \ , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/ , 21:35:53,632 SRMSG18229: Configured topics for channel 'slow': [slow], 21:35:53,651 SRMSG18214: Key deserializer omitted, using String as default, 21:35:53,651 SRMSG18234: Auto-commit disabled for channel slow, 21:35:53,827 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:35:53,827 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:35:53,828 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:35:53,866 SRMSG18248: Key serializer omitted, using String as default, 21:35:53,900 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:35:53,950 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:35:53,954 No Topology producer; Kafka Streams will not be started, 21:35:54,048 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.376s. Listening on: http://0.0.0.0:1104, 21:35:54,048 Profile prod activated. , 21:35:54,048 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:35:54,176 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:35:57,704 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' to Kafka topic 'slow', 21:35:57,813 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
  • Failed in jobs:
    • PR - Linux - JVM build - Latest Version
Failure stacktrace
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 21:35:53,632 SRMSG18229: Configured topics for channel 'slow': [slow], 21:35:53,651 SRMSG18214: Key deserializer omitted, using String as default, 21:35:53,651 SRMSG18234: Auto-commit disabled for channel slow, 21:35:53,827 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:35:53,827 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:35:53,828 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:35:53,866 SRMSG18248: Key serializer omitted, using String as default, 21:35:53,900 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:35:53,950 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:35:53,954 No Topology producer; Kafka Streams will not be started, 21:35:54,048 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.376s. Listening on: http://0.0.0.0:1104, 21:35:54,048 Profile prod activated. , 21:35:54,048 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:35:54,176 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:35:57,704 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' to Kafka topic 'slow', 21:35:57,813 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:134)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:124)
	at io.quarkus.test.utils.LogsVerifier.assertContains(LogsVerifier.java:28)
	at io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection(KafkaGratefulShutdownIT.java:72)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.opentest4j.AssertionFailedError: Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 21:35:53,632 SRMSG18229: Configured topics for channel 'slow': [slow], 21:35:53,651 SRMSG18214: Key deserializer omitted, using String as default, 21:35:53,651 SRMSG18234: Auto-commit disabled for channel slow, 21:35:53,827 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:35:53,827 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:35:53,828 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:35:53,866 SRMSG18248: Key serializer omitted, using String as default, 21:35:53,900 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:35:53,950 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:35:53,954 No Topology producer; Kafka Streams will not be started, 21:35:54,048 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.376s. Listening on: http://0.0.0.0:1104, 21:35:54,048 Profile prod activated. , 21:35:54,048 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:35:54,176 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:35:57,704 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' to Kafka topic 'slow', 21:35:57,813 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@584a6d79 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false>
	at io.quarkus.test.utils.LogsVerifier.lambda$assertContains$0(LogsVerifier.java:30)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)


Copy link

Following jobs contain at least one flaky test:

  • PR - Linux - JVM build - Latest Version

Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11488468330?pr=2122

Flaky tests:


io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

  • Failure message: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__ ____ __ _____ ___ __ ____ ______ , --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ , -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \ , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/ , 21:43:28,684 SRMSG18229: Configured topics for channel 'slow': [slow], 21:43:28,702 SRMSG18214: Key deserializer omitted, using String as default, 21:43:28,702 SRMSG18234: Auto-commit disabled for channel slow, 21:43:28,881 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:43:28,882 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:43:28,883 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:43:28,925 SRMSG18248: Key serializer omitted, using String as default, 21:43:28,959 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:43:29,020 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:43:29,021 No Topology producer; Kafka Streams will not be started, 21:43:29,114 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.408s. Listening on: http://0.0.0.0:1104, 21:43:29,114 Profile prod activated. , 21:43:29,114 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:43:29,249 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:43:32,773 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' to Kafka topic 'slow', 21:43:32,860 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
  • Failed in jobs:
    • PR - Linux - JVM build - Latest Version
Failure stacktrace
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 21:43:28,684 SRMSG18229: Configured topics for channel 'slow': [slow], 21:43:28,702 SRMSG18214: Key deserializer omitted, using String as default, 21:43:28,702 SRMSG18234: Auto-commit disabled for channel slow, 21:43:28,881 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:43:28,882 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:43:28,883 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:43:28,925 SRMSG18248: Key serializer omitted, using String as default, 21:43:28,959 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:43:29,020 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:43:29,021 No Topology producer; Kafka Streams will not be started, 21:43:29,114 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.408s. Listening on: http://0.0.0.0:1104, 21:43:29,114 Profile prod activated. , 21:43:29,114 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:43:29,249 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:43:32,773 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' to Kafka topic 'slow', 21:43:32,860 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:134)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:124)
	at io.quarkus.test.utils.LogsVerifier.assertContains(LogsVerifier.java:28)
	at io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection(KafkaGratefulShutdownIT.java:72)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.opentest4j.AssertionFailedError: Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 21:43:28,684 SRMSG18229: Configured topics for channel 'slow': [slow], 21:43:28,702 SRMSG18214: Key deserializer omitted, using String as default, 21:43:28,702 SRMSG18234: Auto-commit disabled for channel slow, 21:43:28,881 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 21:43:28,882 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 21:43:28,883 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 21:43:28,925 SRMSG18248: Key serializer omitted, using String as default, 21:43:28,959 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32777', is configured to write records to 'slow', 21:43:29,020 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32777', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 21:43:29,021 No Topology producer; Kafka Streams will not be started, 21:43:29,114 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.408s. Listening on: http://0.0.0.0:1104, 21:43:29,114 Profile prod activated. , 21:43:29,114 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 21:43:29,249 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 21:43:32,773 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' to Kafka topic 'slow', 21:43:32,860 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@720bcbc from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false>
	at io.quarkus.test.utils.LogsVerifier.lambda$assertContains$0(LogsVerifier.java:30)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)


@fedinskiy fedinskiy merged commit 05f973b into quarkus-qe:main Oct 24, 2024
7 checks passed
@jedla97 jedla97 deleted the disabled-on-rhbq-and-windows branch October 24, 2024 08:34
@jedla97 jedla97 mentioned this pull request Oct 24, 2024
9 tasks
@michalvavrik michalvavrik removed the triage/flaky-test Signal that flaky tests were detected during CI run label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants