Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DisabledOnRHBQWindowsConditions from testsuite to framework #1377

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Oct 22, 2024

Summary

Moving the DisabledOnRHBQandWindows from testsuite to framework. This anotation to disable test is available only here in my POV it's better to have it defined in framework as it can be used on multiple places.

My motivation: I need to disable snappy test on windows which failing only with RHBQ.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 added the triage/backport-1.5? Quarkus 3.15 stream label Oct 22, 2024
@jedla97 jedla97 requested a review from michalvavrik October 22, 2024 14:31
@michalvavrik michalvavrik merged commit 8103989 into quarkus-qe:main Oct 22, 2024
7 checks passed
This was referenced Oct 22, 2024
@jedla97 jedla97 removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants