-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not enough space error for keycloak container image quay.io/keycloak/keycloak:25.0 #2067
Fix not enough space error for keycloak container image quay.io/keycloak/keycloak:25.0 #2067
Conversation
I believe we need a release of framework with this commit (quarkus-qe/quarkus-test-framework#1351), don't we? |
Nope, because those changes already were bumped with the |
http/http-advanced/src/test/java/io/quarkus/ts/http/advanced/HttpAdvancedIT.java
Show resolved
Hide resolved
85c0942
to
346176d
Compare
http/http-advanced/src/test/java/io/quarkus/ts/http/advanced/BaseHttpAdvancedIT.java
Outdated
Show resolved
Hide resolved
http/http-advanced/src/test/java/io/quarkus/ts/http/advanced/HttpAdvancedIT.java
Show resolved
Hide resolved
09fe70b
to
9c8e09a
Compare
None of those changes actually worked. I misinterpreted the results because, in the PW: I could put also an annotation with the issue that you mentioned here: quarkusio/quarkus#41813 WDYT? |
Following jobs contain at least one flaky test:
Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11256134835?pr=2067 Flaky tests:
Failure stacktrace
|
http/http-advanced/src/test/java/io/quarkus/ts/http/advanced/HttpAdvancedIT.java
Show resolved
Hide resolved
23b451a
to
b71a444
Compare
Unfortunately even removing the test that "seems" the issue, it didn't solve the keycloak container error |
1f0c20e
to
1a13e48
Compare
Following jobs contain at least one flaky test:
Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11272272041?pr=2067 Flaky tests:
Failure stacktrace
|
Following jobs contain at least one flaky test:
Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11272267117?pr=2067 Flaky tests:
Failure stacktrace
Failure stacktrace
|
Following jobs contain at least one flaky test:
Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11272929099?pr=2067 Flaky tests:
Failure stacktrace
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked at the quarkus-qe/quarkus-test-framework#1351 and quarkusio/quarkus#43630 and I am not sure why do we need to set these parameters when there is KeycloakContainer#memoryLimitMiB
. If I understand quarkusio/quarkus#43601 correctly, Keycloak Dev Services does exactly same, just reduce container memory because Keycloak raise to that limit and no more.
But let's say we do, setting JAVA_OPTS
to the -Xms512m -Xmx1g
means that heap can go up to 1g, but resident set size contains also metaspace and the metaspace can push you to OOM as well.
TL;DR; we have container memory limit set to 1000 MiB and you allow 1g for the heap, so what about the rest of RSS? My proposal is to test this well in many runs and link series of success runs with same configuration in the Slack. Thanks
Also, few questions:
- can we simply set
KeycloakContainer#memoryLimitMiB
to higher values for this test? - any idea why it happens only for this test? I can imagine it is hard to tell the reason, but I found 6 other tests with identical Keycloak configuration just by simple fulltext search. And OOM happens on the Keycloak startup, which means it has nothing to do with any
@Test
method at all, netiher with application properties and Quarkus application either (because it happens before Quarkus is started).
This ^^ leads me to thinking that maybe there is some resource leak before HttpAdvancedIT
is even started and by the time that Keycloak starts, there is already so little memory it cannot start.
But that you cannot investigate by guessing, you need more data, add there hooks and printout how much memory space there is on the executor machine disk before Keycloak is started.
Thanks @michalvavrik ,you've come to the same conclusion as me, I said this to Fedor yesterday on Slack: "Related to Keycloak container memory issues, I really think this has nothing to do with the tests." |
Ok printing the memory of the total memory and free memory before start the container seems the issue, Jenkins logs :
|
d4e271e
to
f0f1159
Compare
The issue opened in our TS: |
457a308
to
9ff09eb
Compare
Summary
In our daily jobs, we experienced
OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x00000006af400000, 4034920448, 0) failed; error=' Not enough space' (errno=12)#
.It was some improvements with quarkus-qe/quarkus-test-framework#1351
Apart from that, the' HttpAdvancedIT' test also needs to be updated, and I did with this PR.
I've tested in our Jenkins-job and the test PASSED.
Please select the relevant options.
run tests
phrase in comment)Checklist: