-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set memory limit for Keycloak container #1351
Conversation
@fedinskiy let's review unless you are busy; if so, pleaes request review from me again; thanks! |
Thank you @mabartos |
.../java/io/quarkus/test/services/containers/KeycloakGenericDockerContainerManagedResource.java
Outdated
Show resolved
Hide resolved
quarkus-test-service-keycloak/src/main/java/io/quarkus/test/services/KeycloakContainer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So @mabartos with these modifications it would not be necessary to implement any changes related to JAVA_OPTS_KC_HEAP="-XX:MaxHeapFreeRatio=30 -XX:MaxRAMPercentage=65"
as suggested here--> https://www.keycloak.org/server/containers#_specifying_different_memory_settings ?
Thanks.
Closes quarkus-qe#1350 Signed-off-by: Martin Bartoš <[email protected]>
076cffc
to
df15b8c
Compare
@fedinskiy I added the test.
@jcarranzan it's not suggested. It should only emphasize the approach of setting heap settings via the env var. The default values are @jcarranzan Does the documentation and the example seem confusing to you? I can improve the documentation a bit. |
Ok got it, it's not need modify docs, thank you @mabartos |
run tests |
Closes #1350
Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please check the relevant options
run tests
phrase in comment)Checklist:
I'd propose increasing the memory limit (to 1GiB) for Keycloak instance running in a container for the test suite, as it might be more memory-consuming than the Keycloak dev service: quarkusio/quarkus#43601
Container limit is properly used in
quarkus-test-suite
project:The solution works as expected for my experiments.
It should close issue: quarkusio/quarkus#43630
But these changes should be probably backported to the
quarkus-test-framework:1.5.x
(or not sure what approach is used in such scenarios).cc: @jcarranzan