-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageUtil class #975
Merged
Merged
Add ImageUtil class #975
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
quarkus-test-images/src/main/java/io/quarkus/test/utils/ImageUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package io.quarkus.test.utils; | ||
|
||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
public final class ImageUtil { | ||
|
||
private static final String COLON = ":"; | ||
private static final Map<String, String[]> PROPERTY_TO_IMAGE = new HashMap<>(); | ||
|
||
private ImageUtil() { | ||
// util class | ||
} | ||
|
||
public static String getImageVersion(String imageProperty) { | ||
return getImage(imageProperty)[1]; | ||
} | ||
|
||
public static String getImageName(String imageProperty) { | ||
return getImage(imageProperty)[0]; | ||
} | ||
|
||
private static String[] getImage(String imageProperty) { | ||
return PROPERTY_TO_IMAGE.computeIfAbsent(imageProperty, ip -> { | ||
final String image = System.getProperty(imageProperty); | ||
if (image == null) { | ||
throw new IllegalStateException(String.format("System property '%s' is missing.", imageProperty)); | ||
} | ||
if (!image.contains(COLON)) { | ||
throw new IllegalStateException(String.format("'%s' is not valid Docker image", image)); | ||
} | ||
return image.split(COLON); | ||
}); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about upper case snake case for this map, what convention do you follow? I can easily be wrong here.
I thought upper case snake is usually used for constants, and this variable is modified. I don't have strong opinion, feel free to prove me wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering I wrote same code, let's keep it