Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageUtil class #975

Merged
merged 1 commit into from
Dec 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package io.quarkus.test.utils;

import java.util.HashMap;
import java.util.Map;

public final class ImageUtil {

private static final String COLON = ":";
private static final Map<String, String[]> PROPERTY_TO_IMAGE = new HashMap<>();
Copy link
Member

@michalvavrik michalvavrik Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about upper case snake case for this map, what convention do you follow? I can easily be wrong here.

I thought upper case snake is usually used for constants, and this variable is modified. I don't have strong opinion, feel free to prove me wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering I wrote same code, let's keep it


private ImageUtil() {
// util class
}

public static String getImageVersion(String imageProperty) {
return getImage(imageProperty)[1];
}

public static String getImageName(String imageProperty) {
return getImage(imageProperty)[0];
}

private static String[] getImage(String imageProperty) {
return PROPERTY_TO_IMAGE.computeIfAbsent(imageProperty, ip -> {
final String image = System.getProperty(imageProperty);
if (image == null) {
throw new IllegalStateException(String.format("System property '%s' is missing.", imageProperty));
}
if (!image.contains(COLON)) {
throw new IllegalStateException(String.format("'%s' is not valid Docker image", image));
}
return image.split(COLON);
});
}

}