Add ImageUtil class #975
Merged
Add ImageUtil class #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtroitsk
force-pushed
the
image-util-class
branch
from
dc95b8c to
f18e486
Compare
michalvavrik
reviewed
Dec 8, 2023
quarkus-test-images/src/main/java/io/quarkus/test/utils/ImageUtil.java
Outdated
Show resolved
Hide resolved
| public final class ImageUtil { | ||
|
|
||
| private static final String COMMA = ":"; | ||
| private static final Map<String, String[]> PROPERTY_TO_IMAGE = new HashMap<>(); |
There was a problem hiding this comment.
I'm not sure about upper case snake case for this map, what convention do you follow? I can easily be wrong here.
I thought upper case snake is usually used for constants, and this variable is modified. I don't have strong opinion, feel free to prove me wrong.
There was a problem hiding this comment.
considering I wrote same code, let's keep it
Retrieves image name and version from Maven property
gtroitsk
force-pushed
the
image-util-class
branch
from
f18e486 to
57f4492
Compare
This was referenced Dec 12, 2023
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retrieves image name and version from Maven property. This util class primarily will be used in TS.
It is not included in any test in FW.
Please check the relevant options
run testsphrase in comment)Checklist: