Fix tests using Apicurio registry by using 2.4.x-release Docker image tag as previous tags do not have manifest #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
michalvavrik
requested review from
rsvoboda and
jcarranzan
and removed request for
rsvoboda
|
adding @jcarranzan as we need to fix dailys and @rsvoboda has a lot on his plate already |
jcarranzan
reviewed
Nov 15, 2023
...est-service-kafka/src/main/java/io/quarkus/test/services/containers/model/KafkaRegistry.java
Show resolved
Hide resolved
|
Ok, after my resolved comment an all the checks have passed, it looks good to me, let's merge it! Thank you, Michal. |
michalvavrik
deleted the
feature/use-apicurio-4-x-release-image-docker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried 2.4.2.Final, ..., 2.14.4.Final both on quay.io/apicurio/apicurio-registry-mem and https://hub.docker.com/r/apicurio/apicurio-registry-mem/tags and they just don't seem to have a manifest. Waited until now, but we need to fix TS / FW daily builds so that we don't miss other bugs. Not sure if the issue is temporary or it was an intention. I can't see anything about it here https://www.apicur.io/blog/.
Using 2.14.x stream as upstream Java libraries are adapted with 2.4.14.Final ATM: https://github.com/quarkusio/quarkus/blob/6198267029b4feba6c61153d9feff4a25cb25e23/bom/application/pom.xml#L207
This needs to be released and propagated to TS.
Please check the relevant options
run testsphrase in comment)Checklist: