Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.z] Don't enforce lowercase Kafka registry image name as Apicurio Docker tag don't get recognized #961

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 23, 2023

Summary

Docker tag 2.4.2.final is not recognized, but 2.4.2.Final is.

fixes 1.3.z CI, but we also need to get this fix into TS 3.2 branch.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Backport
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc November 23, 2023 20:39
@mjurc
Copy link
Member

mjurc commented Nov 23, 2023

run tests

@michalvavrik
Copy link
Member Author

well, I am starting to think problem is somewhere else. if you check logs org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/apicurio/apicurio-registry-mem:2.4.2.final, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@2e2a42ba) then docker pull quay.io/apicurio/apicurio-registry-mem:2.4.2.final indeed does not work. bot the tag has big F: 2.4.2.Final. I need to look what is going on.

@michalvavrik michalvavrik changed the title [1.3.z] Fix tests using Apicurio registry by using 2.4.x-release Docker image tag as previous tags do not have manifest [1.3.z] Don't enforce lowercase Kafka registry image name as Apicurio Docker tag don't get recognized Nov 23, 2023
@michalvavrik
Copy link
Member Author

run tests

@mjurc mjurc merged commit 11d3c59 into quarkus-qe:1.3.z Nov 24, 2023
7 checks passed
@michalvavrik michalvavrik deleted the backports/strimzi-fix branch November 24, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants