Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus Platform group id used for external applications as default Quickstarts group id changed #849

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix Quarkus Platform group id used for external applications as default Quickstarts group id changed #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...uarkus/test/services/quarkus/GitRepositoryLocalhostQuarkusApplicationManagedResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import static io.quarkus.test.services.quarkus.GitRepositoryResourceBuilderUtils.cloneRepository;
import static io.quarkus.test.services.quarkus.GitRepositoryResourceBuilderUtils.mavenBuild;
import static io.quarkus.test.services.quarkus.model.QuarkusProperties.PLATFORM_GROUP_ID;
import static io.quarkus.test.utils.MavenUtils.withProperty;

import java.nio.file.Path;
import java.util.List;
Expand Down Expand Up @@ -43,13 +45,20 @@ protected Path getApplicationFolder() {

@Override
protected List<String> prepareCommand(List<String> systemProperties) {
// Dev mode
final List<String> commands;

if (model.isDevMode()) {
return MavenUtils.devModeMavenCommand(model.getContext(), systemProperties);
// Dev mode
commands = MavenUtils.devModeMavenCommand(model.getContext(), systemProperties);
} else {
// JVM or Native
commands = super.prepareCommand(systemProperties);
}

// JVM or Native
return super.prepareCommand(systemProperties);
// set quarkus.platform.group-id
commands.add(withProperty(PLATFORM_GROUP_ID.getPropertyKey(), PLATFORM_GROUP_ID.get()));

return List.copyOf(commands);
}

@Override
Expand Down