Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus Platform group id used for external applications as default Quickstarts group id changed #849

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Aug 3, 2023

Summary

Quarkus Quickstarts platform group id has changed quarkusio/quarkus-quickstarts@cef1faf. We do set explicitly group id for build https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/services/GitRepositoryQuarkusApplication.java#L20, but not for dev mode (or JVM and native) https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/services/quarkus/GitRepositoryLocalhostQuarkusApplicationManagedResource.java#L45 https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/utils/MavenUtils.java#L70. That seems like a bug to me and now, we always set group id explicitly.

Daily build fails because of this.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc August 3, 2023 21:56
@michalvavrik michalvavrik mentioned this pull request Aug 3, 2023
10 tasks
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@michalvavrik michalvavrik merged commit 0034a40 into quarkus-qe:main Aug 3, 2023
@michalvavrik michalvavrik deleted the feature/fix-external-app-platform-group-id branch August 3, 2023 23:36
@michalvavrik michalvavrik mentioned this pull request Aug 4, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants