Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta migration - fix FW injection by migration remaining imports #674

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Jakarta migration - fix FW injection by migration remaining imports #674

merged 1 commit into from
Feb 10, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Feb 9, 2023 •
edited
Loading

Summary

#668 follow-up where I missed javax Inject. Imports are sorted as CI forced me to.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

Blocks quarkus-qe/quarkus-test-suite#1049

@michalvavrik michalvavrik force-pushed the feature/fix-fw-injection branch 5 times, most recently from e1a8e65 to d4d8ff5 Compare February 9, 2023 22:53
@michalvavrik
Copy link
Member Author

run tests

1 similar comment
@michalvavrik
Copy link
Member Author

run tests

fedinskiy
fedinskiy requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please check the CI

...uarkus/test/services/quarkus/OpenShiftS2iGitRepositoryQuarkusApplicationManagedResource.java Outdated Show resolved Hide resolved
@michalvavrik
Copy link
Member Author

I'll check CI ASAP and get back here.

@michalvavrik
Copy link
Member Author

OC native failure is due to There is insufficient memory for the Java Runtime Environment to continue., IMHO not related.

@michalvavrik michalvavrik force-pushed the feature/fix-fw-injection branch from d4d8ff5 to 64e056a Compare February 10, 2023 10:52
@fedinskiy fedinskiy merged commit 233be4d into quarkus-qe:main Feb 10, 2023
@michalvavrik michalvavrik deleted the feature/fix-fw-injection branch February 10, 2023 11:01
@michalvavrik michalvavrik mentioned this pull request Feb 10, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @fedinskiy