Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTLP collector by default with Jaeger #655

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Use OTLP collector by default with Jaeger #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df5563
Use OTLP collector by default with Jaeger
rsvoboda Jan 18, 2023
3ac4e4b
Update jaeger example to depend on default useOtlpCollector value
rsvoboda Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/jaeger/src/test/java/io/quarkus/qe/ClientResourceIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class ClientResourceIT {
private static final String SERVICE_NAME = "test-traced-service";
private static final String CLIENT_ENDPOINT = "/client";

@JaegerContainer(useOtlpCollector = true)
@JaegerContainer()
static JaegerService jaeger = new JaegerService();

@QuarkusApplication
Expand Down
5 changes: 3 additions & 2 deletions quarkus-test-service-jaeger/src/main/java/io/quarkus/test/services/JaegerContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@
int otlpPort() default 4317;

/**
* Switches between {@link #restPort()} and {@link #otlpPort()}. If set to true, the OTLP collector is used.
* Switches between {@link #restPort()} and {@link #otlpPort()}.
* If set to true, the OTLP collector is used. If set to false, the Jaeger collector is used.
*/
boolean useOtlpCollector() default false;
boolean useOtlpCollector() default true;

String expectedLog() default "server started";

Expand Down