Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash host and port to avoid reading them after shutdown #623

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Hash host and port to avoid reading them after shutdown #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...ain/java/io/quarkus/test/services/quarkus/OpenShiftQuarkusApplicationManagedResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ public abstract class OpenShiftQuarkusApplicationManagedResource<T extends Quark
private boolean init;
private boolean running;

private String host;
private int port = -1;

public OpenShiftQuarkusApplicationManagedResource(T model) {
super(model.getContext());
this.model = model;
Expand Down Expand Up @@ -76,15 +79,20 @@ public void stop() {
@Override
public String getHost(Protocol protocol) {
validateProtocol(protocol);
return untilIsNotNull(() -> client.url(model.getContext().getOwner()),
AwaitilitySettings.defaults().withService(getContext().getOwner()));
if (this.host == null) {
this.host = untilIsNotNull(() -> client.url(model.getContext().getOwner()),
AwaitilitySettings.defaults().withService(getContext().getOwner()));
}
return this.host;
}

@Override
public int getPort(Protocol protocol) {
int port = client.isServerlessService(model.getContext().getName()) ? EXTERNAL_SSL_PORT : EXTERNAL_PORT;
validateProtocol(protocol);
return port;
if (this.port == -1) {
this.port = client.isServerlessService(model.getContext().getName()) ? EXTERNAL_SSL_PORT : EXTERNAL_PORT;
}
return this.port;
}

@Override
Expand Down