-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash host and port to avoid reading them after shutdown #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run tests |
Tests from the TS have passed on a local machine, so I consider this ready for review |
@fedinskiy should this changes also go to main branch? |
run tests |
Errors on OCP are not related to the changes. |
Test OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT which was persistently failing, does not call the changed methods, so these failures are non related |
fedinskiy
added a commit
to fedinskiy/quarkus-test-framework
that referenced
this pull request
Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests [1] quarkus-qe#623
fedinskiy
added a commit
to fedinskiy/quarkus-test-framework
that referenced
this pull request
Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests [1] quarkus-qe#623
fedinskiy
added a commit
to fedinskiy/quarkus-test-framework
that referenced
this pull request
Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests [1] quarkus-qe#623
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please check the relevant options
run tests
phrase in comment)Checklist: