Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash host and port to avoid reading them after shutdown #623

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Dec 9, 2022

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from pjgg December 12, 2022 07:33
@rsvoboda
Copy link
Member

run tests

@fedinskiy fedinskiy marked this pull request as ready for review December 12, 2022 11:47
@fedinskiy
Copy link
Contributor Author

Tests from the TS have passed on a local machine, so I consider this ready for review

@pjgg
Copy link
Contributor

pjgg commented Dec 12, 2022

@fedinskiy should this changes also go to main branch?

@pjgg
Copy link
Contributor

pjgg commented Dec 12, 2022

run tests

@pjgg
Copy link
Contributor

pjgg commented Dec 13, 2022

Errors on OCP are not related to the changes.

@pjgg pjgg merged commit b552352 into quarkus-qe:1.1.z Dec 13, 2022
@fedinskiy
Copy link
Contributor Author

Test OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT which was persistently failing, does not call the changed methods, so these failures are non related

fedinskiy added a commit to fedinskiy/quarkus-test-framework that referenced this pull request Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests

[1] quarkus-qe#623
@fedinskiy fedinskiy mentioned this pull request Dec 14, 2022
10 tasks
fedinskiy added a commit to fedinskiy/quarkus-test-framework that referenced this pull request Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests

[1] quarkus-qe#623
fedinskiy added a commit to fedinskiy/quarkus-test-framework that referenced this pull request Dec 14, 2022
This is a port of the fix[1] for occasional failures in 2.7 Interop tests

[1] quarkus-qe#623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants