Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply idea code analysis suggestions #1406

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Apply idea code analysis suggestions #1406

merged 1 commit into from
Nov 15, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Nov 14, 2024 •
edited
Loading

Summary

  • Removes unnecessary constructions
  • Follows last Java conventions where it is possible, simplify expressions
  • Changes deprecated APIs

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk
Copy link
Member Author

run tests

@gtroitsk gtroitsk marked this pull request as ready for review November 14, 2024 13:03
@gtroitsk gtroitsk requested a review from mocenas November 14, 2024 13:03
@gtroitsk
Copy link
Member Author

run tests

mocenas
mocenas requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes are OK. But some needs to be reverted.

quarkus-test-core/src/main/java/io/quarkus/test/bootstrap/BaseService.java Outdated Show resolved Hide resolved
...-test-core/src/main/java/io/quarkus/test/services/quarkus/QuarkusMavenPluginBuildHelper.java Outdated Show resolved Hide resolved
quarkus-test-kubernetes/src/main/java/io/quarkus/test/bootstrap/inject/KubectlClient.java Show resolved Hide resolved
quarkus-test-openshift/pom.xml Show resolved Hide resolved
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java Outdated Show resolved Hide resolved
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java Show resolved Hide resolved
...-test-core/src/main/java/io/quarkus/test/services/quarkus/QuarkusMavenPluginBuildHelper.java Outdated Show resolved Hide resolved
@gtroitsk
Copy link
Member Author

run tests

@gtroitsk gtroitsk requested a review from mocenas November 15, 2024 11:04
mocenas
mocenas approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for OCP CI.

@gtroitsk gtroitsk added the triage/backport-1.5? Quarkus 3.15 stream label Nov 15, 2024
@mocenas mocenas merged commit 77ee8d5 into quarkus-qe:main Nov 15, 2024
9 checks passed
@gtroitsk gtroitsk deleted the fw-cleanup branch November 15, 2024 15:45
@jedla97 jedla97 mentioned this pull request Nov 25, 2024
Merged
12 tasks
@jedla97 jedla97 removed the triage/backport-1.5? Quarkus 3.15 stream label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtroitsk @mocenas @jedla97