Update dependencies #381
Merged
Update dependencies #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedinskiy
force-pushed
the
update/dependencies
branch
6 times, most recently
from
32bd658 to
5d6971f
Compare
rsvoboda
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Changes in general look good to me, a few small things to adjust.
- There should be 3 commits related to the areas highlighted in the description
- Please do not use QQE-XYZ in commit message / PR title, the tracker is private one. In general it's better to provide descriptive commit message, the link to the QQE tracker cam be added into second or third line of the commit message"
Error: StartStopTest.fullMicroProfileNative:241->testRuntime:200 Application FULL_MICROPROFILE in NATIVE consumed 87001 kB, which is over 83000 kB threshold. ==> expected: <true> but was: <false>is very suspicious, it's worth to investigate, it can be a follow-up task (ideally for this / next week)
testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java
Outdated
Show resolved
Hide resolved
testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java
Outdated
Show resolved
Hide resolved
fedinskiy
force-pushed
the
update/dependencies
branch
from
5d6971f to
219a167
Compare
|
Fixes applied, commits changed. Regarding to Startstop: I am investigating this, though locally the tests fails in a different way. I can investigate this further or create a separate task for it. Which one would you prefer? |
|
Give it 2 hours. After that please create a separate task. |
|
An issue: https://issues.redhat.com/browse/QQE-871 |
Make names of several variables more descriptive, make logging more detailed
Since 3.13.0 Quarkus OTEL exporter uses GRPC streams to export traces. Our hacked together OTEL server could not handle that, and was rewritten to conform to OTEL specifications more.
fedinskiy
force-pushed
the
update/dependencies
branch
from
219a167 to
22569bf
Compare
Update of Quarkus to 3.13 yielded some issues. Related tests were changed/disabled
fedinskiy
force-pushed
the
update/dependencies
branch
from
22569bf to
f97357f
Compare
rsvoboda
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our hacked together OTEL server(added in Make 'app-full-microprofile' project closer to what customers do and address engineering team feedback #378) could not handle that and was rewritten to conform to OTEL specifications more.
Related issue: QQE-844