Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'app-full-microprofile' project closer to what customers do and address engineering team feedback #378

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 21, 2024

Changes based on https://issues.redhat.com/browse/QUARKUS-4073, however I must stress this is my opinionated interpretation of the feedback as sometimes the feedback wasn't detailed suggestion:

  • use OpenTelemetry and make sure that Vert.x gRPC OTLP traces exporter is used (not using Jaeger container as we test Startstops without Linux containers)
  • use Micrometer Prometheus registry instead of deprecated MP Metrics
  • test serialization response as that is what most apps do rather than non-Quarkus code like building JWT tokens
  • whether app is ready is more likely to be detected by probes than by requesting static content from index page, therefore the first request is measured by probes endpoint

@michalvavrik michalvavrik force-pushed the feature/make-app-more-real branch 2 times, most recently from e920fc5 to 6b29496 Compare June 21, 2024 13:16
@michalvavrik michalvavrik requested a review from rsvoboda June 21, 2024 16:26
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the changes, just two small items for adjustment.

Assuming you will backport these changes to 3.8 branch to make 3.8 and 3.14 results comparable.

testsuite/pom.xml Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/make-app-more-real branch from 6b29496 to 31888ab Compare June 25, 2024 14:17
testsuite/pom.xml Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/make-app-more-real branch from 31888ab to 6722b84 Compare June 26, 2024 20:35
@michalvavrik michalvavrik force-pushed the feature/make-app-more-real branch from 6722b84 to c03c43b Compare June 26, 2024 20:36
@michalvavrik michalvavrik requested a review from rsvoboda June 26, 2024 20:39
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik!

Please prepare the same change for 3.8 branch. We will need new baseline comparison for 3.8 and main.

@rsvoboda rsvoboda merged commit 9d2ea08 into quarkus-qe:main Jun 27, 2024
9 checks passed
@michalvavrik michalvavrik deleted the feature/make-app-more-real branch June 27, 2024 07:46
@fedinskiy fedinskiy mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants