Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docs #258

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix Docs #258

merged 1 commit into from
Nov 7, 2024

Conversation

brunobat
Copy link
Collaborator

@brunobat brunobat commented Nov 7, 2024

No description provided.

@brunobat brunobat requested a review from gastaldi November 7, 2024 15:38
@brunobat brunobat requested a review from a team as a code owner November 7, 2024 15:38
gastaldi
gastaldi approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs looks fine, there are other (unrelated?) changes that I don't understand if it's right, but I trust you :)

@brunobat
Copy link
Collaborator Author

brunobat commented Nov 7, 2024

The docs looks fine, there are other (unrelated?) changes that I don't understand if it's right, but I trust you :)

The config names were not consistent and I created tests for the new config and legacy compatibility.

@brunobat brunobat merged commit 2203ca1 into quarkiverse:main Nov 7, 2024
1 check passed
@brunobat brunobat mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobat @gastaldi