Sentry Exporter #253
Merged
Sentry Exporter #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmanibus
force-pushed
the
sentry
branch
4 times, most recently
from
133317e to
1b4767d
Compare
brunobat
requested changes
Nov 7, 2024
...us-opentelemetry-exporter-sentry/integration-tests/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...us-opentelemetry-exporter-sentry/integration-tests/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...try/integration-tests/src/test/java/io/quarkiverse/opentelemetry/exporter/it/SentryTest.java
Outdated
Show resolved
Hide resolved
...try/integration-tests/src/test/java/io/quarkiverse/opentelemetry/exporter/it/SentryTest.java
Outdated
Show resolved
Hide resolved
...ain/java/io/quarkiverse/opentelemetry/exporter/sentry/beans/SentrySpanProcessorProducer.java
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkiverse/opentelemetry/exporter/sentry/config/SentryConfig.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkiverse/opentelemetry/exporter/sentry/config/SentryConfig.java
Outdated
Show resolved
Hide resolved
quarkus-opentelemetry-exporter-sentry/runtime/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
rmanibus
force-pushed
the
sentry
branch
4 times, most recently
from
a9adca2 to
324e71b
Compare
gastaldi
reviewed
Nov 11, 2024
quarkus-opentelemetry-exporter-sentry/runtime/src/main/resources/application.properties
Show resolved
Hide resolved
|
@rmanibus did a commit with the aim of fixing the docs |
|
@brunobat are we good to merge this ? |
brunobat
reviewed
Nov 11, 2024
docs/modules/ROOT/pages/quarkus-opentelemetry-exporter-sentry.adoc
Outdated
Show resolved
Hide resolved
quarkus-opentelemetry-exporter-sentry/runtime/src/main/resources/application.properties
Show resolved
Hide resolved
|
Just waiting to see if we get a solution for the doc configs section |
|
@gastaldi can you plesse help with this? |
gastaldi
reviewed
Nov 25, 2024
Comment on lines
+40
to
+43
| <dependency> | ||
| <groupId>io.sentry</groupId> | ||
| <artifactId>sentry-jul</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
There are some particularities specially when building to native. I'd recommend depending on https://github.com/quarkiverse/quarkus-logging-sentry instead of the sentry libraries
I see |
|
Pretty eager for this one. Any updates on work to be done/anything I can help with to get this merged in? |
|
Will take a look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on @LaurentTreguier work
relevant thread:
quarkusio/quarkus#19798