Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint_copyright_checker doesn't work with pylint 3 #6351

Closed
mpharrigan opened this issue Nov 17, 2023 · 1 comment · Fixed by #6751
Closed

pylint_copyright_checker doesn't work with pylint 3 #6351

mpharrigan opened this issue Nov 17, 2023 · 1 comment · Fixed by #6751
Assignees
@pavoljuhas
Labels
good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@mpharrigan
Copy link
Collaborator

The custom pylint rule in dev_tools/pylint_copyright_checker doesn't work with the latest major version of pylint. The specific problem is that IRawChecker doesn't exist anymore. I quickly snooped the changelog and I think this is relevant: pylint-dev/pylint#8404
@mpharrigan mpharrigan added the kind/bug-report Something doesn't seem to work. label Nov 17, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days

@tanujkhattar tanujkhattar added the triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on label Jan 3, 2024
@pavoljuhas pavoljuhas mentioned this issue Jan 3, 2024
Closed
@pavoljuhas pavoljuhas added good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. labels Sep 4, 2024
@mhucka mhucka mentioned this issue Sep 4, 2024
Open
@pavoljuhas pavoljuhas mentioned this issue Oct 3, 2024
Open
@pavoljuhas pavoljuhas self-assigned this Oct 4, 2024
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this issue Oct 4, 2024
@pavoljuhas
Adjust pylint_copyright_checker for the pylint-3 API
9e49b6a 
Follow the `examples/custom_raw.py` in the pylint repository.

Fixes quantumlib#6351
@pavoljuhas pavoljuhas mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavoljuhas pavoljuhas

Labels
good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update copyright checker and switch to pylint-3 pavoljuhas/Cirq
3 participants
@pavoljuhas @mpharrigan @tanujkhattar