Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_tools/pylint fails with pylint-3 and later #210

Open
pavoljuhas opened this issue Oct 3, 2024 · 3 comments · Fixed by #211
Open

dev_tools/pylint fails with pylint-3 and later #210

pavoljuhas opened this issue Oct 3, 2024 · 3 comments · Fixed by #211
Assignees

Comments

@pavoljuhas
Copy link
Contributor

The pylint execution fails on loading the custom 'pylint_copyright_checker' plugin.
Related to quantumlib/Cirq#6351

@pavoljuhas
Copy link
Contributor Author

There is no pylint_copyright_checker.py file in this repository, but there
is also no wrong-or-nonexistent-copyright-notice check enabled in dev_tools/.pylintrc.

pylint-3 seems to error on plugins that do not exists, whereas pylint-2 silently ignored them.
It also discovers a plenty of lint issues that were not reported before (perhaps missing --recursive=yes).

This should be re-scoped to syncing with cirq pylint settings.

@pavoljuhas
Copy link
Contributor Author

@dstrain115 - please reopen, there are open TODO items in dev_tools/.pylintrc for rules that need to be fixed and enabled.

@dstrain115
Copy link
Collaborator

@solodov If you want to help with these, we need to enable the pylint tests one-by-one and fix the resulting pylint errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants