CompatHelper: bump compat for FastGaussQuadrature to 1, (keep existing compat) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
david-pl
force-pushed
the
compathelper/new_version/2023-10-03-01-18-32-188-04063377320
branch
from
7cee582 to
bcfe9c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 24 24
Lines 3018 3018
=======================================
Hits 2818 2818
Misses 200 200 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
JuliaApproximation/FastGaussQuadrature.jl#128 seems to imply this version bump only included deprecations, nothing actually breaking. FastGaussQuadrature does not seem to follow semver too closely, so we might end up with a break when they update to 1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
FastGaussQuadraturepackage from0.5to0.5, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.