Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLEASE DO NOT COMMIT DIRECTLY ON THE master BRANCH! #128

Closed
hyrodium opened this issue Oct 3, 2023 · 3 comments
Closed

PLEASE DO NOT COMMIT DIRECTLY ON THE master BRANCH! #128

hyrodium opened this issue Oct 3, 2023 · 3 comments

Comments

@hyrodium
Copy link
Collaborator

hyrodium commented Oct 3, 2023

@dlfivefifty

I have some requests and opinions about the latest release v1.0.0.

  • We don't have an agreement about releasing v1.0.0 yet in this thread (Update make.jl for Documenter.jl v1.0.0 #127).
  • I believe we are not ready for v1.0.0 because the API is not stable. (i.e. Some deprecated methods are not removed.)
  • Adding deprecations is not considered as a breaking change.
  • Please just approve my PRs because I also have the privilege of merge.
  • I am one of the core maintainers of this package, so please feel free to discuss and request reviews.

I tried to change the repository settings to protect the master branch, but I didn't have enough permissions for that.

@dlfivefifty
Copy link
Member

Umm I’m the owner of the package. The API has been stable and there’s no reason to not tag v1.0

@hyrodium
Copy link
Collaborator Author

I’m the owner of the package.

I truly respect the role you've played, and I deeply appreciate the effort you've put into maintaining this package. Thank you.

Considering that this package is under the JuliaApproximation organization and not an individual account like dlfivefifty, could we have more discussions and PR-based development?

The API has been stable and there’s no reason to not tag v1.0

As I've mentioned multiple times (#123 (comment), #123 (comment), #128 (comment)), I believe the API is not yet fully stable. Specifically, it would be better not to include deprecated functions like gausschebyshev and besselroots in v1.0.0.

I opened a new issue for v2.0.0: #129

@dlfivefifty
Copy link
Member

I’m also the owner of JuliaApproximation. Endless discussions are not necessarily productive and sometimes one just has to make decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants