Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Japanese translation of docs/internals_input_callback_reg.md #9752

Merged
merged 2 commits into from
Aug 1, 2020
Merged

[Docs] Japanese translation of docs/internals_input_callback_reg.md #9752

merged 2 commits into from
Aug 1, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jul 18, 2020

Description

Add a Japanese translation of docs/internals_input_callback_reg.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jul 18, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

hsgw
hsgw reviewed Jul 26, 2020
View reviewed changes
docs/ja/internals_input_callback_reg.md Outdated Show resolved Hide resolved
docs/ja/internals_input_callback_reg.md Outdated Show resolved Hide resolved
shelaf
shelaf reviewed Jul 26, 2020
View reviewed changes
Copy link
Contributor

@shelaf shelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最初のところしかまだ見れてないですがひとまずコメントします

docs/ja/internals_input_callback_reg.md Outdated Show resolved Hide resolved
docs/ja/internals_input_callback_reg.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 30, 2020 08:34
hsgw
hsgw approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@hsgw hsgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtei
Copy link
Contributor

mtei commented Jul 31, 2020

I think this is ready to merge.

@noroadsleft noroadsleft merged commit 0d405ad into qmk:master Aug 1, 2020
@noroadsleft
Copy link
Member

ありがとうございました！

@umi-umi umi-umi deleted the internals_input_callback_reg.md-japanese-translation branch August 9, 2020 09:09
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@umi-umi @nicocesar
[Docs] Japanese translation of docs/internals_input_callback_reg.md (q…
f7a1e93 
…mk#9752)

* add internals_input_callback_reg.md translation

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi
[Docs] Japanese translation of docs/internals_input_callback_reg.md (q…
6906d36 
…mk#9752)

* add internals_input_callback_reg.md translation

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@hsgw hsgw hsgw approved these changes

@mtei mtei mtei approved these changes

@shelaf shelaf shelaf approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umi-umi @mtei @noroadsleft @shelaf @hsgw