Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Japanese translation of docs/cli_development.md #9699

Merged
merged 4 commits into from
Jul 22, 2020
Merged

[Docs] Japanese translation of docs/cli_development.md #9699

merged 4 commits into from
Jul 22, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jul 10, 2020

Description

Add a Japanese translation of docs/cli_development.md

I accidentally removed branch during pull request of this file.
It caused the deletion of pull request.

I taged on my local repository just before the deletion, so I make this pull request from it.
Sorry for the trouble.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jul 10, 2020

元の pr は、#9513 ですね。

@mtei mtei requested a review from a team July 10, 2020 19:58
shelaf
shelaf approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@shelaf shelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うっかりcloseしてしまったのでしょうか。同じ内容に見えるのでapprove

mtei
mtei reviewed Jul 20, 2020
View reviewed changes
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 20, 2020 18:16
@mtei
Copy link
Contributor

mtei commented Jul 20, 2020

I think this is ready to merge.

@mtei mtei merged commit 3f0292d into qmk:master Jul 22, 2020
@mtei
Copy link
Contributor

mtei commented Jul 22, 2020

Thanks !

@umi-umi umi-umi deleted the cli_development.md-japanese-translation branch August 9, 2020 09:08
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@umi-umi @nicocesar
[Docs] Japanese translation of docs/cli_development.md (qmk#9699)
d93e791 
* add cli_development.md translation

* update based on comment

* update based on comment

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi
[Docs] Japanese translation of docs/cli_development.md (qmk#9699)
a953f86 
* add cli_development.md translation

* update based on comment

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@shelaf shelaf shelaf approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umi-umi @mtei @shelaf