Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/cli_development.md #9513

Closed

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jun 23, 2020

Description

Add a Japanese translation of docs/cli_development.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jun 23, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
docs/ja/cli_development.md Outdated Show resolved Hide resolved
cli.log.info('Reading from %s and writing to %s', cli.args.filename, cli.args.output)
```

# テスト、リントおよびフォーマット (oh my!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

忘れていましたが、これなくしてしまっていいですよね…?

Suggested change
# テスト、リントおよびフォーマット (oh my!)
# テスト、リントおよびフォーマット

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご指摘ありがとうございます。
あまり意味が無さそうなので、削除したもので更新しました。

@mtei mtei requested a review from a team June 30, 2020 11:54
@umi-umi umi-umi closed this Jul 10, 2020
@umi-umi umi-umi deleted the cli_development.md-japanese-translation branch July 10, 2020 16:49
@umi-umi umi-umi restored the cli_development.md-japanese-translation branch July 10, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants