-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Japanese translation of docs/cli_development.md #9513
Closed
umi-umi
wants to merge
3
commits into
qmk:master
from
umi-umi:cli_development.md-japanese-translation
Closed
[Docs] Japanese translation of docs/cli_development.md #9513
umi-umi
wants to merge
3
commits into
qmk:master
from
umi-umi:cli_development.md-japanese-translation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。 |
13 tasks
shelaf
reviewed
Jun 28, 2020
shelaf
reviewed
Jun 29, 2020
docs/ja/cli_development.md
Outdated
cli.log.info('Reading from %s and writing to %s', cli.args.filename, cli.args.output) | ||
``` | ||
|
||
# テスト、リントおよびフォーマット (oh my!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
忘れていましたが、これなくしてしまっていいですよね…?
Suggested change
# テスト、リントおよびフォーマット (oh my!) | |
# テスト、リントおよびフォーマット |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘ありがとうございます。
あまり意味が無さそうなので、削除したもので更新しました。
shelaf
approved these changes
Jul 10, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Japanese translation of docs/cli_development.md.
Types of Changes
Issues Fixed or Closed by This PR
Checklist