Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new keyboard, the N87 #9663

Merged
merged 11 commits into from
Jul 24, 2020
Merged

Add a new keyboard, the N87 #9663

merged 11 commits into from
Jul 24, 2020

Conversation

DeskDaily
Copy link
Contributor

Adding a new keyboard, the N87. A TKL PCB that supports standard, tsangan, and symmetric standard bottom row

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/nightly_boards/n87/config.h Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/info.json Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/keymaps/tsangan/keymap.c Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/keymaps/tsangan/keymap.c Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/n87.h Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/n87.h Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/n87.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 6, 2020 12:22
keyboards/nightly_boards/n87/rules.mk Outdated Show resolved Hide resolved
keyboards/nightly_boards/n87/readme.md Show resolved Hide resolved
keyboards/nightly_boards/n87/info.json Show resolved Hide resolved
@Erovia Erovia requested a review from a team July 8, 2020 19:01
…ta pin B7, enabled audio click, disabled music mode
@DeskDaily
Copy link
Contributor Author

Latest commit also have updated keymaps to enable/adjust audio click

@zvecr zvecr requested a review from Erovia July 17, 2020 12:36
@drashna drashna merged commit 0adf03c into qmk:master Jul 24, 2020
@drashna
Copy link
Member

drashna commented Jul 24, 2020

Thanks!

@DeskDaily DeskDaily deleted the n87 branch July 30, 2020 10:48
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* Add new keyboard, the N87

* Deleted config.h and readme.md on tsangan keymap folder

* Edited layout names on keymap.c and n87.h. Disabled audio

* Edited files based on requested changes, re-enabled audio on extra data pin B7, enabled audio click, disabled music mode

* Updated the wiring matrix for symmetric_standard layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants