Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] added swiftrax/cowfish #9621

Merged
merged 11 commits into from
Jul 11, 2020
Merged

[keyboard] added swiftrax/cowfish #9621

merged 11 commits into from
Jul 11, 2020

Conversation

swiftrax
Copy link
Contributor

@swiftrax swiftrax commented Jul 1, 2020

Description

  • Added folder for my other keyboards
  • Added keyboard called 'cowfish'

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest that LAYOUT is refactored to LAYOUT_all

keyboards/handwired/swiftrax/cowfish/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jul 3, 2020
@zvecr zvecr requested a review from a team July 3, 2020 23:07
@Erovia Erovia requested review from fauxpark and zvecr July 7, 2020 18:26
@Erovia Erovia requested review from fauxpark and a team July 9, 2020 19:22
@swiftrax swiftrax mentioned this pull request Jul 9, 2020
Merged
6 tasks
@swiftrax swiftrax requested a review from zvecr July 10, 2020 21:15
@Erovia Erovia merged commit 63fe920 into qmk:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swiftrax @Erovia @fauxpark @zvecr