Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add src/swiftrax/cowfish.json #206

Merged
merged 8 commits into from
Sep 15, 2020
Merged

Add src/swiftrax/cowfish.json #206

merged 8 commits into from
Sep 15, 2020

Conversation

swiftrax
Copy link

@swiftrax swiftrax commented Jul 9, 2020 •
edited
Loading

Description

Add cowfish.json

QMK Pull Request

qmk/qmk_firmware#9922

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@swiftrax swiftrax changed the title Swiftrax Add scr/swiftrax/cowfish.json Jul 10, 2020
@swiftrax swiftrax changed the title Add scr/swiftrax/cowfish.json Add src/swiftrax/cowfish.json Jul 10, 2020
wilba
wilba reviewed Aug 4, 2020
View reviewed changes
src/swiftrax/cowfish.json
Comment on lines +3 to +4
"vendorId": "0x04D8",
"productId": "0xEB53",
Copy link
Contributor

@wilba wilba Aug 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the QMK PR:

#define VENDOR_ID       0x7161
#define PRODUCT_ID      0x5239

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry opened a new PR changing VID and PID
qmk/qmk_firmware#9922

@swiftrax swiftrax requested a review from wilba August 8, 2020 07:41
@wilba wilba merged commit ee581e6 into the-via:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilba wilba Awaiting requested review from wilba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swiftrax @wilba