Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VIA support for Noxary 268.2 #9451

Merged
merged 11 commits into from
Jun 23, 2020
Merged

Conversation

Rozakiin
Copy link
Contributor

@Rozakiin Rozakiin commented Jun 17, 2020

Description

Updates existing VIA support to be inline with QMK and VIA guidelines

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Rozakiin Rozakiin changed the title Update VIA support for Noxary268.2 Update VIA support for Noxary 268.2 Jun 17, 2020
@Rozakiin Rozakiin marked this pull request as ready for review June 17, 2020 20:31
keyboards/noxary/268_2/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/noxary/268_2/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/noxary/268_2/readme.md Outdated Show resolved Hide resolved
keyboards/noxary/268_2/readme.md Outdated Show resolved Hide resolved
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Jun 17, 2020
@fauxpark fauxpark requested a review from a team June 17, 2020 22:18
Rozakiin and others added 4 commits June 18, 2020 10:43
Flip order of layout image and title

Co-authored-by: Ryan <[email protected]>
Flip order of layout image and title

Co-authored-by: Ryan <[email protected]>
bullet point keyboard maintainer

Co-authored-by: Ryan <[email protected]>
Change list style

Co-authored-by: Ryan <[email protected]>
@Rozakiin Rozakiin requested review from fauxpark and removed request for a team June 18, 2020 09:48
@fauxpark fauxpark requested a review from a team June 19, 2020 04:58
@noroadsleft noroadsleft merged commit a8bb584 into qmk:master Jun 23, 2020
@noroadsleft
Copy link
Member

Thanks!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Update readme.md description

* Enable bootmagic lite

* Update USB descriptor

* Add modern led code

* Update default keymap for readability

* Update default keymap readme with layout image

* Add VIA keymap

* Update keyboards/noxary/268_2/keymaps/default/readme.md

Flip order of layout image and title

* Update keyboards/noxary/268_2/keymaps/via/readme.md

Flip order of layout image and title

* Update keyboards/noxary/268_2/readme.md

bullet point keyboard maintainer

* Update keyboards/noxary/268_2/readme.md

Change list style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants