Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Tune doctor's udev rule checking to match #8750 #9080

Merged
merged 1 commit into from
May 15, 2020
Merged

CLI: Tune doctor's udev rule checking to match #8750 #9080

merged 1 commit into from
May 15, 2020

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented May 12, 2020

Description

Tune doctor's udev rule checking to match #8750.
It will detect the old rules and suggests updating them.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia added cli qmk cli command python labels May 12, 2020
@Erovia Erovia requested a review from a team May 12, 2020 20:33
fauxpark
fauxpark approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma weak

@skullydazed skullydazed merged commit 6b54f3c into qmk:master May 15, 2020
@Erovia Erovia deleted the cli/doctor_udev branch May 16, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erovia @fauxpark @skullydazed