Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update udev rules to use TAG+="uaccess". #8750

Merged
merged 3 commits into from
Jun 7, 2020

Conversation

petejohanson
Copy link
Contributor

Description

  • udev for several years now has supported "dynamic" permissions
    for device access for the logged in user, that avoids needing
    custom groups, or making devices world writable.
  • Update the docs for udev rules to use the "newer" uaccess
    approach.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia requested a review from a team April 9, 2020 18:10
@drashna drashna requested a review from a team April 12, 2020 20:35
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/python/qmk/cli/doctor.py needs updating to reflect these docs changes, though this might then cause issue as how do we tell users they need to update existing files content.

@petejohanson
Copy link
Contributor Author

lib/python/qmk/cli/doctor.py needs updating to reflect these docs changes, though this might then cause issue as how do we tell users they need to update existing files content.

@zvecr Any objections to updating that Python code to be able to fallback to detecting the "old" version, and allowing it, but warning in that scenario about updating them?

Erovia added a commit to Erovia/qmk_firmware that referenced this pull request May 12, 2020
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #9080 for the qmk doctor part.

docs/faq_build.md Outdated Show resolved Hide resolved
docs/faq_build.md Show resolved Hide resolved
docs/faq_build.md Outdated Show resolved Hide resolved
docs/faq_build.md Outdated Show resolved Hide resolved
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* udev for several years now has supported "dynamic" permissions
  for device access for the logged in user, that avoids needing
  custom groups, or making devices world writable.
* Update the docs for udev rules to use the "newer" `uaccess`
  approach.
@petejohanson petejohanson force-pushed the docs/faq-build-udev-rules-uaccess branch from f583a71 to a81bf28 Compare June 7, 2020 02:45
@Erovia Erovia merged commit b9a3848 into qmk:master Jun 7, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants