Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More community layout support for legacy KBD67 PCBs #8933

Merged
merged 4 commits into from
May 7, 2020
Merged

More community layout support for legacy KBD67 PCBs #8933

merged 4 commits into from
May 7, 2020

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Apr 26, 2020

Description

Adding support for the new 65_ansi_blocker_split_bs layout from #8793 to the old (pre-MKII) KBD67 PCBs, as well as a couple other layouts where appropriate:

  • rev1: Adding 65_ansi layout. (I'm pretty sure this PCB also supports at least 65_iso, and probably 65_ansi_blocker & 65_ansi_blocker_split_bs too; however, I can't find a picture of the original KBD65 PCB to verify that.)
  • rev2: Adding 65_ansi_blocker_split_bs. (The layout is already here, just under a different name. Added an alias for backwards compatibility.)
  • hotswap: Adding 65_ansi_blocker_split_bs. (This is a fixed-layout hotswap keyboard, so 65_ansi_blocker_split_bs is in fact the only layout this particular PCB supports.)

I also moved my personal kbd67/hotswap keymap into the 65_ansi_blocker_split_bs community layout directory. (Left other folks' keymaps alone, of course.) I can do that in a separate PR if you'd prefer.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bcat
Copy link
Contributor Author

bcat commented Apr 26, 2020

Two Travis errors seem unrelated:

kbd67/rev1:mechmerlin doesn't build since @mechmerlin's 65_ansi keymap has one too many _______ entries in the _CL layer. This keymap doesn't build with the NK65 either, so I think it's an error in the keymap rather than the community layout.

kbd67/rev1:yanfali is a few bytes too big, but I'm not making the keyboard bigger, so I think this is unrelated as well.

@drashna
Copy link
Member

drashna commented Apr 29, 2020

The Travis CI errors are okay, as they're community layouts. The default layouts compile, and other community layouts compile. So, it's okay/safe to ignore those errors, in this case.

@drashna drashna requested a review from a team April 29, 2020 10:54
@zvecr zvecr requested a review from noroadsleft May 1, 2020 20:12
@noroadsleft noroadsleft merged commit 81c648e into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Community layout support for KBD67 hotswap

* Community layout support for KBD67 rev1

* Community layout support for KBD67 rev2

* Move bcat's KBD67 hotswap layout to community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants