New 65 ANSI Blocker layouts: Split BS, Tsangan #8793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace
- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.
drashna
approved these changes
Apr 19, 2020
noroadsleft
requested changes
Apr 20, 2020
There was a problem hiding this comment.
Notes
layouts/default/65_ansi_blocker_split_bs/default_65_ansi_blocker/keymap.cneeds to be renamed tolayouts/default/65_ansi_blocker_split_bs/default_65_ansi_blocker_split_bs/keymap.clayouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.cneeds to be renamed to
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker_tsangan/keymap.c- The suggestions I made to the
65_ansi_blocker_tsanganlayout remove the split Backspace, using a 2u Backspace instead. The reason for this is to make it consistent with the 60% Tsangan layouts, which only change the bottom row sizing.60_ansi_tsanganand60_iso_tsanganstill use 2u Backspace;60_tsangan_hhkbgets its split Backspace from being HHKB layout, rather than being Tsangan.
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.c
Outdated
Show resolved
Hide resolved
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.c
Outdated
Show resolved
Hide resolved
|
Implemented feedback. Ready for review. |
fauxpark
requested changes
Apr 23, 2020
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker_tsangan/keymap.c
Outdated
Show resolved
Hide resolved
fauxpark
reviewed
Apr 23, 2020
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker_tsangan/keymap.c
Outdated
Show resolved
Hide resolved
fauxpark
approved these changes
Apr 23, 2020
noroadsleft
approved these changes
Apr 25, 2020
|
Thanks! |
13 tasks
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Add 65 ANSI Blocker Split BS default layout - Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace * Add 65 ANSI Blocker Tsangan default layout - Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration. * Fix file names * Fix 65_ansi_blocker_tsangan keymap * Fix 65_ansi_blocker_split_bs alignment * Fix readme name for 65_ansi_blocker_split_bs * Change 65_ansi_blocker_tsangan to 2u backspace * Change spaces in preview to NBSP * Change more spaces in preview to NBSP (right-alt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 65 ANSI Blocker layout variations as default layouts: Split BS & Tsangan. Since many 65 ANSI Blocker keyboards also support support split backspace and 7u bottom row configurations, adding these default layouts will enable community layout support for these popular configurations going forward.
Types of Changes
Issues Fixed or Closed by This PR
Checklist