Audio enable corrections (3/3) #8904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2020 18:04
…config.h on keyboards that have the audio feature enabled $qmk_firmware> grep -rnIE 'AUDIO_ENABLE.*yes' -l | xargs sed 's|output on port C6|output (needs a pin configured in config.h, see docs/feature_audio.md)|' -i
…config.h on all other keyboards $qmk_firmware> grep -rnIE 'AUDIO_ENABLE.*no' -l | xargs sed 's|output on port C6|output (needs a pin configured in config.h, see docs/feature_audio.md)|' -i
JohSchneider
force-pushed
the
audio_enable_corrections_3
branch
from
f84321c to
3541bff
Compare
13 tasks
|
As mentioned in #8901 800+ files is too many in one PR, lets slow down a bit and work incrementally. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update AUDIO-feature comment in rules.mk of AVR boards
Description
these changes on way to many files do exactly one thing, replacing strings in rules.mk
from
-AUDIO_ENABLE = yes # Audio output on port C6
to
+AUDIO_ENABLE = yes # Audio output (needs a pin configured in config.h, see docs/feature_audio.md)
while preserving the yes/no selection, and leaving keyboards that have already something other then the default comment 'Audio output on port C6'
Types of Changes
Issues Fixed or Closed by This PR
Checklist