Audio_Enable, AVR template update #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohSchneider
force-pushed
the
audio_enable_corrections
branch
from
e9c539d to
be309c3
Compare
|
Chances of 800+ files getting reviewed is super slim, and generally we ask for PRs to be broken into chunks (50-100 depending on change). Also, I would rather drive this via #6165 than preempt changes, lets get it to a solid point and then work out what we want to do. |
|
thanks for the feedback - the changes do 90% of the time the same thing... i can break off the ones which do exactly the same if that helps? |
JohSchneider
force-pushed
the
audio_enable_corrections
branch
from
be309c3 to
6ffbcf5
Compare
|
there - this should be better (?) |
|
Lets get the wording approved here before raising all the extra PRs, given its just adding rework for you. |
|
okay - that's reasonable :-) |
|
hm, did i make some mistake creating this PR for travis to complain about |
not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits
JohSchneider
force-pushed
the
audio_enable_corrections
branch
from
6ffbcf5 to
9ebf490
Compare
drashna
approved these changes
Apr 29, 2020
fauxpark
requested changes
Apr 29, 2020
|
should PR #8904 be reopened and refactored as well? to avoid future misconfigurations on exiting keyboards? |
|
"and removed request for qmk/collaborators" err... why did that happen when i only requested a re-review for fauxpark? |
Co-Authored-By: Ryan <[email protected]>
JohSchneider
force-pushed
the
audio_enable_corrections
branch
from
0db53f5 to
f7d472d
Compare
zvecr
approved these changes
May 1, 2020
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
JohSchneider
added a commit
to JohSchneider/yamsek.qmk_firmware
that referenced
this pull request
May 7, 2020
noroadsleft
pushed a commit
that referenced
this pull request
May 10, 2020
* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with #8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
noroadsleft
pushed a commit
that referenced
this pull request
May 15, 2020
* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with #8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk
noroadsleft
pushed a commit
to noroadsleft/qmk_firmware
that referenced
this pull request
May 22, 2020
* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with qmk#8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
noroadsleft
pushed a commit
to noroadsleft/qmk_firmware
that referenced
this pull request
May 28, 2020
* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with qmk#8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Branch point for 2020 May 30 Breaking Change * audio-configuration: template: audio_avr.c does NOT default to C6 not on its own, it needs a pin configured per define in config.h for audio to actually work otherwise only parts of the code are included in the firmware, wasting space and possibly breaking builds because auf hitting the firmware-size limits * audio-configuration: strip comment to bare essentials Co-Authored-By: Ryan <[email protected]> * revert future change Co-authored-by: James Young <[email protected]> Co-authored-by: Johannes <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: zvecr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quantum/audio/audio_avr.c does not implicitly enable any default pins used as output - unless the correct define is set
the comment automatically generated from quantum/template/avr/rules.mk is hence misleading
Description
if a user enables audio and forgets to define a pin on AVR based projext, they'll end up with the audio-feature not working, wasting space/bytes in the firmware and - worst case - breaking the build because the firmware size exceeds the maximum
these patches address this by correcting the comment in the avr template,
Types of Changes
Issues Fixed or Closed by This PR
Checklist