Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Japanese translation of docs/feature_hd44780.md #8875

Merged
merged 4 commits into from
Apr 27, 2020
Merged

[Docs] Japanese translation of docs/feature_hd44780.md #8875

merged 4 commits into from
Apr 27, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Apr 21, 2020

Description

Add a Japanese translation of docs/feature_hd44780.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from mtei and a team April 21, 2020 13:39
@mtei
Copy link
Contributor

mtei commented Apr 21, 2020

@shelaf @s-show @hsgw よかったらレビューお願いします。

s-show
s-show reviewed Apr 25, 2020
View reviewed changes
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Apr 25, 2020
View reviewed changes
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
shelaf
shelaf suggested changes Apr 26, 2020
View reviewed changes
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
mtei
mtei reviewed Apr 26, 2020
View reviewed changes
docs/ja/feature_hd44780.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team April 26, 2020 16:10
@mtei
Copy link
Contributor

mtei commented Apr 26, 2020

I think this is ready to merge.

noroadsleft
noroadsleft approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit f220e7d into qmk:master Apr 27, 2020
@noroadsleft
Copy link
Member

どうもありがとうございました！

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request Apr 27, 2020
@umi-umi @brandonschlack
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
a274ddc 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@umi-umi @violet-fish
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
0147c5f 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
@umi-umi umi-umi deleted the feature_hd44780.md-japanese-translation branch May 3, 2020 03:36
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@umi-umi @lorenzoernesto
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
e61312d 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@umi-umi @sowbug
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
38f9eaa 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@umi-umi @turky
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
a3ce792 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@umi-umi @jakobaa
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
bc16600 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@umi-umi @sjmacneil
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
3391aea 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi
[Docs] Japanese translation of docs/feature_hd44780.md (qmk#8875)
8657642 
* add feature_hd44780.md translation

* update based on comment

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-show s-show s-show approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@mtei mtei mtei approved these changes

@shelaf shelaf shelaf approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@umi-umi @mtei @noroadsleft @shelaf @s-show @zvecr