Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Absinthe keyboard #8769

Merged
merged 17 commits into from
Apr 19, 2020
Merged

[Keyboard] Add Absinthe keyboard #8769

merged 17 commits into from
Apr 19, 2020

Conversation

cfbender
Copy link
Contributor

@cfbender cfbender commented Apr 12, 2020 •
edited
Loading

Description

Adding the absinthe keyboard, a design by myself and /u/reggatronics. Soon to be sold by KeyHive.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Apr 12, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current form, this PR cannot be accepted due to the submodule changes in lib/chibios, lib/chibios-contrib, lib/ugfx.

@cfbender
Copy link
Contributor Author

cfbender commented Apr 12, 2020 •
edited
Loading

@zvecr I'm not quite as familiar with the submodule workflow, would this just be going into the submodules and running git reset --hard? edit: I see that that didn't do anything in my local repo, not sure how these changes even happened

@cfbender cfbender force-pushed the absinthe branch 3 times, most recently from fa88dcb to 7988187 Compare April 12, 2020 05:06
@cfbender
Copy link
Contributor Author

After too many force pushes, I may have gotten it I think.

ridingqwerty
ridingqwerty requested changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some convention and alignment/formatting stuff really.

keyboards/absinthe/rules.mk Outdated Show resolved Hide resolved
keyboards/absinthe/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/absinthe/absinthe.h Outdated Show resolved Hide resolved
keyboards/absinthe/absinthe.h Outdated Show resolved Hide resolved
keyboards/absinthe/absinthe.h Outdated Show resolved Hide resolved
keyboards/absinthe/absinthe.h Outdated Show resolved Hide resolved
keyboards/absinthe/absinthe.h Outdated Show resolved Hide resolved
keyboards/absinthe/config.h Outdated Show resolved Hide resolved
keyboards/absinthe/config.h Outdated Show resolved Hide resolved
keyboards/absinthe/config.h Outdated Show resolved Hide resolved
@cfbender
Copy link
Contributor Author

Great suggestions, thanks @ridingqwerty!

@drashna drashna changed the title Add Absinthe keyboard [Keyboard] Add Absinthe keyboard Apr 19, 2020
@drashna drashna merged commit 7e1c0bd into qmk:master Apr 19, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@cfbender @kujawakk
[Keyboard] Add Absinthe keyboard (qmk#8769)
49c599d 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@cfbender @violet-fish
[Keyboard] Add Absinthe keyboard (qmk#8769)
1c057bf 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@cfbender @lorenzoernesto
[Keyboard] Add Absinthe keyboard (qmk#8769)
7dfe99f 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@cfbender @sowbug
[Keyboard] Add Absinthe keyboard (qmk#8769)
3293de8 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@cfbender @turky
[Keyboard] Add Absinthe keyboard (qmk#8769)
4d71ab4 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@cfbender @jakobaa
[Keyboard] Add Absinthe keyboard (qmk#8769)
c85f868 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@cfbender @sjmacneil
[Keyboard] Add Absinthe keyboard (qmk#8769)
3c46526 
* Initial absinthe setup

* Update Absinthe files

* Add absinthe ANSI layout

* Update absinthe keymaps

* Update Absinthe for rev3

* Flip encoder pins

* Fix rules.mk

* Update absinthe files

* Fix absinthe ansi config

* Add RGB

* Change rules for absinthe for firmware size

* Fix pins for rev4

* Fix pins and GESC

* Remove GESC from ANSI layout

* Rebase upstream/master

* Update formatting and convention from 8769 feedback

* Format rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfbender @drashna @ridingqwerty @zvecr